Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@notification.app triggers loading of association :app #410

Closed
loadhigh opened this issue Feb 8, 2018 · 0 comments · Fixed by #421
Closed

@notification.app triggers loading of association :app #410

loadhigh opened this issue Feb 8, 2018 · 0 comments · Fixed by #421

Comments

@loadhigh
Copy link
Contributor

loadhigh commented Feb 8, 2018 •
edited
Loading

rpush/lib/rpush/daemon/gcm/delivery.rb

Line 146 in 54f28a6

'Authorization' => "key=#{@notification.app.auth_key}")

We already have @app and do not need the an extra trip to the DB for each notification sent. The db query is outside of the with_database_reconnect_and_retry block, which is a problem.
loadhigh pushed a commit to loadhigh/rpush that referenced this issue Mar 1, 2018
@henry-yang-sap
@notification.app triggers loading of association :app
a3f7717 
fixes rpush#410
@loadhigh loadhigh mentioned this issue Mar 1, 2018
Merged
loadhigh added a commit to loadhigh/rpush that referenced this issue Mar 2, 2018
@loadhigh
@notification.app triggers loading of association :app
ab673b8 
fixes rpush#410
loadhigh added a commit to loadhigh/rpush that referenced this issue Mar 2, 2018
@loadhigh
@notification.app triggers loading of association :app
a27a82a 
fixes rpush#410
sthkindacrazy pushed a commit to sthkindacrazy/rpush that referenced this issue Mar 14, 2018
@loadhigh @sthkindacrazy
@notification.app triggers loading of association :app
a7a4154 
fixes rpush#410
ormus2002 pushed a commit to ormus2002/rpush that referenced this issue Apr 28, 2020
@loadhigh
@notification.app triggers loading of association :app
3115f6b 
fixes rpush#410
ormus2002 pushed a commit to ormus2002/rpush that referenced this issue May 4, 2020
@loadhigh
@notification.app triggers loading of association :app
b988bfe 
fixes rpush#410
Adrian1707 pushed a commit to Adrian1707/rpush that referenced this issue Apr 24, 2024
@loadhigh
@notification.app triggers loading of association :app
0d8a5f3 
fixes rpush#410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

@notification.app triggers loading of association :app loadhigh/rpush
1 participant
@loadhigh