Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for critical alerts #502

Merged
merged 1 commit into from Aug 14, 2019

Conversation

servn
Copy link
Contributor

@servn servn commented May 16, 2019

@drn
Copy link
Contributor

drn commented Aug 14, 2019

Hi @servn - apologies for months-late reply to this PR.

This looks great! I'll merge this in and update the changelog.

Are you interested in helping maintain rpush?

@drn drn merged commit d62dff4 into rpush:master Aug 14, 2019
@aried3r
Copy link
Member

aried3r commented Aug 14, 2019

I believe this adds too many migrations (only one is needed) and doesn't add the 4.1.2 migration to the test suite.

I think these issues should be addressed before releasing.

@drn
Copy link
Contributor

drn commented Aug 15, 2019

@aried3r Should have waited for your review. Sounds good - I can take on addressing in the next few days if @servn is unable to.

@aried3r aried3r mentioned this pull request Sep 5, 2019
4 tasks
Adrian1707 pushed a commit to Adrian1707/rpush that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants