Drop support for Rails 4.2 #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 4.2 has reached EOL with the release of Rails 6. It has also caused additional work recently to make CI work properly. With this, we can remove the workarounds and focus on future version.
aried3r
commented
Jan 2, 2020
| @@ -35,7 +35,7 @@ Gem::Specification.new do |s| | |||
| s.add_runtime_dependency 'net-http-persistent' | |||
| s.add_runtime_dependency 'net-http2', '~> 0.14' | |||
| s.add_runtime_dependency 'jwt', '>= 1.5.6' | |||
| s.add_runtime_dependency 'activesupport' | |||
| s.add_runtime_dependency 'activesupport', '>= 5.0' | |||
There was a problem hiding this comment.
We can discuss this change. Without this, people can still install future rpush versions on Rails 4.2, but there's no guarantee it will and I'd rather prevent issues from being opened for unsupported Rails versions. WDYT?
There was a problem hiding this comment.
👍 Makes sense to me. Worth noting that in changelog + doing a minor version update
There was a problem hiding this comment.
Thanks for the feedback!
I'll leave this PR open another week or so since some people might be on holidays still. :)
drn
approved these changes
Jan 2, 2020
Adrian1707
pushed a commit
to Adrian1707/rpush
that referenced
this pull request
Apr 24, 2024
Drop support for Rails 4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 4.2 has reached EOL with the release of Rails 6. It has also
caused additional work recently to make CI work properly. With this, we
can remove the workarounds and focus on future version.