Resolves Rails 7 Time.now.to_s deprecation warning #630
Conversation
gregblake
force-pushed
the
resolve_deprecation_warning
branch
from
84b058b
to
eabc590
Compare
gregblake
force-pushed
the
resolve_deprecation_warning
branch
from
eabc590
to
56a5266
Compare
|
For some time now, GitHub Actions seems to have problems with Rails 5.2 with Ruby 2.3 which cancels all the other runs. Perhaps with the next version where we'll support Rails 7, we can also drop Ruby 2.3 and keep Rails 5.2 support for a little longer. What do you think? |
|
I'm in favor of doing that, @aried3r. The ruby-lang team ended all support for Ruby 2.3 in 2019, so I think it's reasonable to drop support in rpush at this time. And the Rails team will continue supporting Rails 5.2 until June 2022, so I like the idea of rpush supporting 5.2 for a bit longer. |
|
Ok, I've opened #631 and finally the CI has successful runs again. My only concern is that there are apparently still a lot of Ruby 2.3 users https://stats.rubygems.org/. But for those, the old gem versions should continue to work. I'll go forward with dropping support and wait a bit more for feedback this week before shipping a new major release. |
As @culov mentioned on #628, the following deprecation warning happens when upgrading to Rails 7:
DEPRECATION WARNING: Time#to_s(:db) is deprecated. Please use Time#to_formatted_s(:db) instead. (called from log at /Users/greg/code/rpush/lib/rpush/logger.rb:72)This PR resolves the deprecation warning and closes #628.