Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple simultaneous sessions #4

Closed
rpwoodbu opened this issue Jan 20, 2014 · 1 comment
Closed

Allow multiple simultaneous sessions #4

rpwoodbu opened this issue Jan 20, 2014 · 1 comment
Assignees

Comments

@rpwoodbu
Copy link
Owner

This will likely require a major UI change (which needs to happen anyway, as it is currently hideous), but also some changes to the code to allow multiple "instances". Some work toward this has already been done with the GetPOSIX() call; it should be able to distinguish which instance to use by looking at the current thread ID.

@rpwoodbu
Copy link
Owner Author

rpwoodbu commented Feb 2, 2014

Implemented in SHA 7a00275.

It turned out I didn't need a major UI change, not any changes to the NaCl module. But I'm not perfectly satisfied with the UI, either. The initial session setup window stays loaded all the time, just minimized when you connect. Go back to it to start another session. If you close that window, it may be difficult to get it back without closing all sessions. On Linux, I find that I can just go back to the "Apps" page and launch it again. But on Chrome OS, clicking on the app in the Apps "drawer" (not the dock) just puts the latest Mosh window into focus, without calling onLaunched().

Furthermore, I cannot find a way to prevent closing of a window by accident. This seems to be a purposeful design decision for Chrome Packaged Apps. So that won't do it.

Anyway, perfect is the enemy of good, so I'm calling this done.

@rpwoodbu rpwoodbu closed this as completed Feb 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant