Use pyarrow.ffi to allocate intermediate C structures
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Jan 18, 2022
pitrou
reviewed
Jan 18, 2022
pitrou
reviewed
Jan 18, 2022
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
- Ensure that correct R function `packageVersion` is called. - Use single-quoted string in Python whenever possible - Use alphabetical order in class name declaration in converter dict.
|
One of commit messages says: Can you open an issue if there is a test still segfaulting? Thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion at #2, the way that pointers are allocated has changed in the Arrow R package master branch, with a release (7.0.0) coming soon. In particular, the internal functions
allocate_arrow_*()anddelete_arrow_*()now work with external pointers (EXTPTRSXP) rather thanuintptr_tcasted todoubleand wrapped in a numeric vector. The unit tests for the import/export interface usepyarrow.ffito allocate and delete the intermediatestruct ArrowArray/Schema/ArrayStream...I think it makes sense to do that here, too, and results in a slightly cleaner pattern (because cffi takes care of the deleting with garbage collection).Happy to take a different approach if needed!
Some references that might be useful when reviewing: