Worker class organization #1784
Conversation
The Redis connection may fail for several reasons. As the connection can be (1) explicitly passed to the worker or (2) implicity set, this will improve the Connection configuration by setting a timeout to the socket, and adding an ExponentialBackoff Retry logic.
…r RedisPy versions
Codecov ReportBase: 94.93% // Head: 94.91% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1784 +/- ##
==========================================
- Coverage 94.93% 94.91% -0.03%
==========================================
Files 51 51
Lines 7740 7744 +4
==========================================
+ Hits 7348 7350 +2
- Misses 392 394 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@selwin this doesn't make sense after |
|
Hey sorry it's very hard for me to spot the changes, even if I compare this branch to the commit before I pulled in the PR with black formatting c2e6d95...162f335 . Any specific commit I should look at? |
|
No commit - this branch is actually a single commit, the rest of them were already merged. You won't be able to compare properly indeed - but you can just open the worker file, fold it all and just open the Worker class, that way you'll see how it's organized. |
Small organization effort to make related methods grouped together: no changes in logic - it should be easy to see the organization with
Workerclass folded. Was separates "geographically" the work horse related methods (there was a suggestion a while ago to completely separate this). This was built on top of #1753Command to ignore moved methods (it should be all greyed out):
git -c color.diff.newMoved=black -c color.diff.oldMoved=black diff --color-moved=plain --unified=0