-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add posibility to use RedisCluster as connection Class #2030
Open
MykolaBordakov
wants to merge
19
commits into
rq:master
Choose a base branch
from
MykolaBordakov:support-redis-cluster
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1c2ce99
Add posibility to use RedisCluster as connection Class
MykolaBordakov 99c0c63
add tests
yurnov 55935a1
reformat with black
yurnov 6a5d4b1
fix duplicated TestWorker
yurnov 9042f45
another attempt to fix linter
yurnov ca49aa5
attemmpt to fix tests
yurnov a2ba737
remove a extra line that added by mistake
yurnov 6d2484b
Change sybtax ib worker connection tests
MykolaBordakov 4d48811
Add RQTestCase
MykolaBordakov 8bb43d8
Remuve #worker.connection_timeout = 10
MykolaBordakov ecbc5fc
Updade RQTestCase with redis cluster connection
MykolaBordakov c518563
Updade RQTestCase with redis cluster connection
MykolaBordakov 3ee4bfc
reformat with black
yurnov 35d841d
reformat with ruff
yurnov a38242c
Merge branch 'rq:master' into support-redis-cluster
MykolaBordakov a4dd141
Remove broken tests.
MykolaBordakov 7b6ee06
Remove broken tests.
MykolaBordakov 2b92254
reformatted with black
yurnov f6480a8
linter: remove unused import of RedisCluster
yurnov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd also need to test this so test coverage doesn't go down. An easy way to do this would be to move this logic to a separate
setup_connection()
and pass bothRedis
andRedisCluster
instances into it so we can easily test this.