Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Retry type hint more exact #2097

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hongquan
Copy link

@hongquan hongquan commented Jun 4, 2024

The current type hint of Retry makes MyPy check failed when user passes a tuple to interval parameter, though that usage is correct.

@selwin
Copy link
Collaborator

selwin commented Jul 18, 2024

Mind making the tests pass so I can merge this in? @hongquan

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.88%. Comparing base (2de9491) to head (b11097a).
Report is 73 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
+ Coverage   93.61%   93.88%   +0.26%     
==========================================
  Files          28       30       +2     
  Lines        3760     3991     +231     
==========================================
+ Hits         3520     3747     +227     
- Misses        240      244       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hongquan
Copy link
Author

@selwin The failed test case is not related to this PR and it happens for older stack (Redis server v5 and redis-py v3.5). Could we just drop support for those stack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants