Allow passing backend classes from CLI and other APIs #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
jezdez
commented
Jan 24, 2017
| @@ -626,7 +626,7 @@ class TimeoutTestCase: | |||
| def setUp(self): | |||
| # we want tests to fail if signal are ignored and the work remain | |||
| # running, so set a signal to kill them after X seconds | |||
| self.killtimeout = 10 | |||
| self.killtimeout = 15 | |||
There was a problem hiding this comment.
FYI this was the only way I was able to fix a slow subprocess call in the pypy env on Travis CI.
jezdez
commented
Jan 24, 2017
| @@ -123,7 +124,7 @@ def create(cls, func, args=None, kwargs=None, connection=None, | |||
| job._instance = func | |||
| job._func_name = '__call__' | |||
| else: | |||
| raise TypeError('Expected a callable or a string, but got: {}'.format(func)) | |||
| raise TypeError('Expected a callable or a string, but got: {0}'.format(func)) | |||
There was a problem hiding this comment.
Change needed to work on Python 2.6.
|
Wow, this is a big PR. I'll need some time to review this. If possible, next time please split them into smaller, logically grouped PRs :) |
|
@selwin I'm sorry for the size but I don't see how I could have cut the PR for passing the backend classes into smaller chunks, it just was in a lot of places missing. I'd be happy to update the patch if there is a better way to handle passing around those classes of course. |
…LI and other APIs This includes: - a partial refactor of the CLI to organize the shared options - extends the tests in areas where passing custom backend classes makes sense - allow setting the core CLI options as env vars - minor cosmetic changes here and there
3 similar comments
|
Thanks for the PR @jezdez ! |
|
@selwin Happy to :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to rq/Flask-RQ2#2 and rq/Flask-RQ2#12. While debugging those issues I've found many inconsistencies how the backend classes are used throughout the RQ code base, basically making it currently impossible to fully override job, queue, worker or connection classes.
This should be backward-compatible, but any testing in real-world projects would be appreciated.