Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API should support nil as parameter #1073

Closed
otoolep opened this issue Oct 13, 2022 · 5 comments · Fixed by #1074
Closed

API should support nil as parameter #1073

otoolep opened this issue Oct 13, 2022 · 5 comments · Fixed by #1074

Comments

@otoolep
Copy link
Member

otoolep commented Oct 13, 2022

https://rqlite.slack.com/archives/C0324J4LC91/p1665626647783139
@otoolep
Copy link
Member Author

otoolep commented Oct 13, 2022

It supports it fine, actually. Looks like a Go client issue.

@otoolep otoolep closed this as completed Oct 13, 2022
@otoolep
Copy link
Member Author

otoolep commented Oct 13, 2022

https://rqlite.slack.com/archives/C0324J4LC91/p1665629560821889

@otoolep otoolep reopened this Oct 13, 2022
@otoolep
Copy link
Member Author

otoolep commented Oct 13, 2022

Actually, may not quite be right.

@otoolep
Copy link
Member Author

otoolep commented Oct 13, 2022 •
edited 

$ curl -XPOST 'http://kotsadm:password@10.43.141.224:4001/db/execute?pretty&timings' -H "Content-Type: application/json" -d '[
    ["INSERT INTO test(name, value) VALUES(?, ?)", "fiona", null]
]'
unsupported type

@sgalsaleh
Copy link
Contributor

Note: this is only an issue with parameter binding. Title can be changed to something like:

"API should support null values when using parameter binding"

@otoolep otoolep mentioned this issue Oct 13, 2022
Merged
@otoolep otoolep linked a pull request Oct 13, 2022 that will close this issue
Support nil as a paramterized value #1074
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support nil as a paramterized value rqlite/rqlite
2 participants
@otoolep @sgalsaleh