Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response content length problem #908

Closed
tiswo opened this issue Oct 20, 2021 · 5 comments
Closed

response content length problem #908

tiswo opened this issue Oct 20, 2021 · 5 comments

Comments

@tiswo
Copy link
Contributor

tiswo commented Oct 20, 2021

hi,I found that when the leader responds to the request of the follower node, the length of protobuf is uint16, which causes the content to be truncated when the number of query lines is large。

The code is in the in the file cluster/service.go handleconn method

@otoolep
Copy link
Member

otoolep commented Oct 20, 2021

Yes, I noticed that recently and should address ASAP. Unfortunate bug.

Are you actually generating responses larger than 64K, or is this just hypothetical? You could work around it by directly querying the leader at all times.

https://github.com/rqlite/rqlite/blob/master/DOC/DATA_API.md#disabling-request-forwarding

@otoolep
Copy link
Member

otoolep commented Oct 20, 2021

#909 will bump the max size to 4MB. I can't go bigger without a backwards-incompatible change, so anything larger will have to wait until 7.0 (or fork the code yourself and modify).

@otoolep
Copy link
Member

otoolep commented Oct 20, 2021

And thanks, @tiswong, for the report.

@otoolep
Copy link
Member

otoolep commented Oct 20, 2021

Will be fixed in 6.6.2.

@otoolep otoolep closed this as completed Oct 20, 2021
@tiswo
Copy link
Contributor Author

tiswo commented Oct 21, 2021

Will be fixed in 6.6.2.

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants