Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding/removing elements #93

Closed
reachcalvyn opened this issue Dec 25, 2021 · 4 comments
Closed

Adding/removing elements #93

reachcalvyn opened this issue Dec 25, 2021 · 4 comments

Comments

@reachcalvyn
Copy link

To reproduce the issue, please do the following in the fiddle: https://jsfiddle.net/s56k8aum/3/

  1. Add First Image
  2. Remove First Image
  3. Add First Image (this causes exception)

Could you please maybe add a method similar to reset or something and call it "refresh"? Basically "refresh" would walk the DOM and refresh based on changes in the DOM.

@midzer
Copy link
Owner

midzer commented Apr 22, 2022

@reachcalvyn Thanks for reporting this (possible) bug!

@viliusle can you have a look at this one? I have no clue why it doesn't work in the fiddle.

@viliusle
Copy link
Collaborator

I will try to look at this later.

@reachcalvyn
Copy link
Author

Any update on this issue? I looked at the source code and there are a bunch of TODO statements so it seems the issue may have been already known during development. I am using this in prod and would really appreciate it if this can be fixed.

@midzer
Copy link
Owner

midzer commented Dec 23, 2022

Thanks alot for your contribution @viliusle.

I just double checked this and it's working fine.

@midzer midzer closed this as completed Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants