Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No/wrong recalculating of counter after removal of item #100

Closed
domaxistd opened this issue Jun 21, 2022 · 6 comments
Closed

No/wrong recalculating of counter after removal of item #100

domaxistd opened this issue Jun 21, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@domaxistd
Copy link

Hello,
it seems that the counter does not recalculate after an item is removed.

  1. i add several images to the lightbox -> counter is right
  2. i remove an image -> counter is wrong (shows too much items, numbers are mixed)

Is there any workaround or quick fix?

Thanks in advance!
Maxi

@midzer
Copy link
Owner

midzer commented Jun 23, 2022

Hi @domaxistd

first of all, thanks for opening this issue.

I have to investigate, never used the tobii counter feature myself. Looks like it's related to #93.

@midzer midzer added the bug Something isn't working label Jun 23, 2022
@domaxistd
Copy link
Author

domaxistd commented Jun 29, 2022

Thanks for the fast respond! @midzer

Another problem that occurs is that when i remove and add multiple items, the lightbox shows too much items.
For example:

  • i have 3 items added to the lightbox
  • the lightbox counter shows 8 items
  • i can swipe 8 times before the lightbox closes itself even though there are only 3 items added (it loops through the 3 items)

I have already tried to reset the lightbox after i remove an item but that doesn't seem to work.

Maybe this helps you find the problem.

@domaxistd
Copy link
Author

Any progress or findings yet?

@midzer
Copy link
Owner

midzer commented Dec 23, 2022

@domaxistd Sorry, I was rather busy the last months. Now, over the holidays I can investigate.

@midzer
Copy link
Owner

midzer commented Dec 24, 2022

Should be fixed by b84f9be

Can you give it a try, @domaxistd?

@domaxistd
Copy link
Author

@midzer problem solved, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants