Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove istanbul from package.json #110

Merged
merged 1 commit into from
May 25, 2021

Conversation

shamrickus
Copy link
Contributor

@shamrickus shamrickus commented May 4, 2021

Since Istanbul is no longer supported, this is producing npm audit warnings

npm WARN deprecated istanbul@0.4.5: This module is no longer maintained, try this instead:
npm WARN deprecated   npm i nyc
npm WARN deprecated Visit https://istanbul.js.org/integrations for other alternatives.

This PR removes it form package.json. Since travis already installs the package manually this should not break CI, and all tests still pass

It also updates package-lock.json as it appears that was not updated with the 0.8 release

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.372% when pulling 220c7a6 on shamrickus:remove-istanbul into 38995eb on rquadling:master.

@shamrickus shamrickus changed the title Remove istanbul from dependencies Remove istanbul from package.json May 5, 2021
@rquadling rquadling merged commit f74d82a into rquadling:master May 25, 2021
@rquadling
Copy link
Owner

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants