Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add py35 support #28

Merged
merged 7 commits into from
Sep 19, 2020
Merged

feat: add py35 support #28

merged 7 commits into from
Sep 19, 2020

Conversation

munagekar
Copy link
Contributor

@munagekar munagekar commented Sep 19, 2020

Please consider supporting python 3.5. I have made the following changes

  • Fixed Lint
  • Replaced f-strings with format strings for py 3.5
  • Replaced enum.auto with actual number for py 3.5
  • Updated the variable annotations for py 3.5.
  • Added a standard gitignore
  • Update setup.cfg for python 3.5.

I have ran the test suite on python 3.5.9 as well as python 3.8.2. It works on both.

@rr-
Copy link
Owner

rr- commented Sep 19, 2020

-1 for importing directly from typing thus polluting global namespace with myriad of inconsistent generic names
-1 for adding bloated .gitignore that holds settings specific to IDEs that most contributors will never even use rather than project-specific stuff
-1 for weird indentation that is not compatible with black

Why do you need Python 3.5?

@munagekar
Copy link
Contributor Author

@rr- Thank you for the quick review.

-1 for importing directly from typing thus polluting global namespace with myriad of inconsistent generic names

I'll revert this

-1 for adding bloated .gitignore

I'll revert this

  • 1 for weird indentation that is not compatible with black

I'll format files with black and fix indentation.

Why do you need Python 3.5?

I am trying to add this as a dependency for kubeflow/pipelines.

@rr- rr- merged commit 9b588df into rr-:master Sep 19, 2020
@rr-
Copy link
Owner

rr- commented Sep 19, 2020

released as 0.7.3; thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants