Add tests for setting autocomplete delimiters & support no delimiters #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests now use the completion_func_for_source fixture, which is a factory generating a function from the passed in source (previously available from the scope outside the function)
rr-
approved these changes
Nov 10, 2020
With no autocomplete delimiters, all of the characters to the left of the cursor are compared for a match. This is useful in situations where it is not important for the completion to occur in the middle of the text, and it is perhaps more important that delimiter characters are allowed in the phrase(s) to autocomplete themselves. One example case this helps is where the autocomplete phrase may contain a space (eg. multi-part personal names); if the delimiter set also includes a space then all name-parts before the space may be neglected in the match. This is particularly apparent when backspacing and autocompleting multiple times. Tests added
neiljp
force-pushed
the
2020-11-08-autocomplete-delimiters
branch
from
f538573
to
2db418b
Compare
|
@rr- I squashed the last two commits and updated that commit text. If you've happy with that then based on your approval this should be good to merge. |
|
Thanks @neiljp do you need to get this version released on PyPI or are you planning any further PRs? |
|
@rr- I don't have any further PRs planned right now, so I'd be happy with having a new release of this 👍 |
|
Sorry for the delay. It's released on PyPI as 0.12 :)
…On Tue, Nov 17, 2020 at 10:13:57AM -0800, Neil Pilgrim wrote:
@rr- I don't have any further PRs planned right now, so I'd be happy with having a new release of this 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On exploring a fix for #13, I saw there was already a
set_autocomplete_delims.After an initial refactor of the common
complfunction into a factory fixture, this PR adds tests for the above method, initially with parametrization demonstrating how the problem observed in zulip-terminal can be resolved (or at least worked around), then expanding it to illustrate behavior when the autocomplete list contains phrases with word separators which are not a space - at this point simply expanding test coverage.The last commit(s) extend the functionality and test cases to allow setting the autocomplete delimters to be an empty string, ie. no characters - this essentially allows any character in the autocomplete phrases, but matches all text from the start of the text box.
Note that I've left the the last two commits separate for now, but these can squashed before merging.
(currently this emphasizes that the existing code is broken when passed an empty string)