Add support for limit_chars argument for ReadlineEdit. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - Adds a new parameter argument 'max_char' to ReadlineEdit that restricts adding character beyond the limit in the Edit widget. - Prevents initializing of Edit widget with an edit_text longer than provided limit_char, by slicing the extra part. - Allow pasting text only upto the limit specified in the above parameter. - Adds test for _insert_char_at_cursor. Tests amended.
rr-
approved these changes
Apr 8, 2021
|
Thanks, released as 0.13 |
|
@rr- Thanks for the merge - I also think this could be good upstream depending on the activity there, though would still need integration here in terms of the other commands like paste? |
|
Unfortunately I don't understand the question. |
|
@rr- I meant whether this feature belongs in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be several use-cases, where you want to restrict the user input into a
ReadlineEditwidget to not go beyond a particular limit, this PR makes it possible for clients to specify amax_charargument when initializing aReadlineEditwidget so that the user can't input text beyond that limit.In particular
zulip-terminalhas such a use-case, where it needsReadlineEditwidgets for stream and topic to only accept input up to 60 characters.Relevant discussion: