Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amd: Add Phoenix (Zen 4) CPU ID #3645

Merged
merged 1 commit into from
Nov 11, 2023
Merged

amd: Add Phoenix (Zen 4) CPU ID #3645

merged 1 commit into from
Nov 11, 2023

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Nov 11, 2023 •
edited

I've done minimal testing to ensure that this works (using the usual Zen workaround).

This covers (at least) the Ryzen 7840U.

@khuey
Copy link
Collaborator

khuey commented Nov 11, 2023

What does "minimal testing" mean? Did you run make check?

@bgamari
Copy link
Contributor Author

bgamari commented Nov 11, 2023 •
edited

I ran make check, noted that it shows the same failures that my Ryzen 3 box exhibits, and ensured that I was able to record, replay, and use reverse breakpoints on a program that I have recently used rr to debug.

@khuey khuey merged commit d9e4547 into rr-debugger:master Nov 11, 2023
2 of 4 checks passed
@khuey
Copy link
Collaborator

khuey commented Nov 11, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bgamari @khuey