Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candlestick outline #57

Closed
EugeneMeles opened this issue Feb 5, 2016 · 6 comments
Closed

Candlestick outline #57

EugeneMeles opened this issue Feb 5, 2016 · 6 comments

Comments

@EugeneMeles
Copy link

react-stockcharts(zooming) /re upload/:
no_zoom

Example chart(zooming):
examle_chart

@rrag
Copy link
Owner

rrag commented Feb 5, 2016

how did you get the first image? I dont see that behavior when I zoom

@EugeneMeles
Copy link
Author

The first it only image zoom, not chart zooming.
I want to get a black frame around the body of the candlestick. Like second chart.

@EugeneMeles
Copy link
Author

Add stroke array on CandlestickSeries
<CandlestickSeries stroke={{ up: "#000000", down: "#000000" }}/>
work only on SVG (need canvas+svg)
example:
svg

@rrag
Copy link
Owner

rrag commented Feb 6, 2016

I will change both fill and stroke to accept a function or string like

https://github.com/rrag/react-stockcharts/blob/next/src/lib/series/HistogramSeries.jsx#L28-L30

@rrag
Copy link
Owner

rrag commented Feb 6, 2016

in v0.4

rrag added a commit that referenced this issue Feb 7, 2016
rrag added a commit that referenced this issue Feb 7, 2016
change fill, stroke and wickStroke to accept a color as string or a function.
@rrag
Copy link
Owner

rrag commented Feb 20, 2016

still not released to npm, and all docs need updats

but code examples are updated and available
http://rrag.github.io/react-stockcharts-next/documentation.html#/brush

@rrag rrag closed this as completed Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants