Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate using run-clang-tidy #35

Open
rrbutani opened this issue Oct 20, 2019 · 1 comment
Open

investigate using run-clang-tidy #35

rrbutani opened this issue Oct 20, 2019 · 1 comment

Comments

@rrbutani
Copy link
Owner

Unclear if this truly goes and grabs stuff from the compdb.

Unless there's a clang-format analogue, we may just want to stick with:

  • clang-format -i for fmt
  • run-clang-format for fmt-check
  • clang-tidy --fix --fix-erors for tidy
  • clang-tidy for tidy-check
@rrbutani
Copy link
Owner Author

rrbutani commented Oct 20, 2019 •
edited
Loading

run-clang-tidy pulls in clang-apply-replacements, which is already in the container and common.ninja

rrbutani added a commit that referenced this issue Oct 20, 2019
@rrbutani
Add format-check, tidy, and tidy-check targets + a check target (and …
7fdd901 
…a fix target!)

Closes #22.

There are potentially other tools we could use for the tidy target (`run-clang-tidy`; see #35).
Additionally there's `clang-apply-replacements` which remains in the container and in `common.ninja` but isn't used. Intead check is currently just tidy + fmt. This is probably fine.

More words on this in the next commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rrbutani