-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test suite for DefinitelyTyped #22
Conversation
Thanks so much, this looks great! Ignore the CircleCI build failing for now, that's my fault (broken cache). I can't test this right now, but I'll pull later tonight and check out the results from the test runs Thanks again 😄 this is great to test against even more libraries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran prettier against your branch 🙂 Not official repo guidelines, but I should add them 😅
I updated the
|
Nice! 🎉 Yes, there are indeed a lot of errors ;) One note: I think you ran |
As suggested in #20, this adds a new test suite for testing the compilation of all type definitions in
DefinitelyTyped
, in the same way asflow-typed
is currently tested.The implementation is pretty much the same as for
flow-typed
, some code is even duplicated.Please let me know if you want me to refactor/clean that up, or if you are fine with it as is for now.
Note: A test run for compiling all
DefinitelyTyped
types (currently 7744!) takes a while (~ 10 minute on my MacBook)For the output from
node docs/find-error.js
see below: