Feature/sub pathfinding #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidlertime
approved these changes
Feb 15, 2020
|
LeftOrRight ist eine private Variable, insofern ist es eindeutig
1NG3M4R <notifications@github.com> schrieb am So., 16. Feb. 2020, 15:47:
… ***@***.**** commented on this pull request.
------------------------------
In Assets/Scripts/DataTypes/Vertices/TeeSection.cs
<#83 (comment)>:
> + if(this._leftOrRight.Equals(from))
+ if(this._leftOrRight.Equals(to))
+ throw new System.Exception("From and to are the same Edge");
was ist leftOrRight? ist das eindeutig? wenn nein ist das ne Fehlerquelle
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#83?email_source=notifications&email_token=AHOLDJ26BRXKZNDYDZFSE7LRDFGZHA5CNFSM4KVZQHR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVWCF7Q#pullrequestreview-359408382>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHOLDJ2TGRFJ43BVF6XDEELRDFGZHANCNFSM4KVZQHRQ>
.
|
1NG3M4R
reviewed
Feb 16, 2020
|
Es wird eine Dictionary mit Listen von Subroutes erstellt, nämlich |
funketh
reviewed
Feb 16, 2020
funketh
reviewed
Feb 18, 2020
funketh
reviewed
Feb 18, 2020
funketh
reviewed
Feb 18, 2020
|
Ist aber unschön
…On Tue, 18 Feb 2020, 13:36 Richard Fuchs, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Assets/Scripts/DataTypes/Vertices/EndPoint.cs
<#83 (comment)>:
> + public void SetWeights()
+ {
+ _routeProbabilities = new RouteProbabilities(_weights, routingTable.Where(kvp => kvp.Value != null).Select(kvp => kvp.Key).ToList());
}
Wir ja nur einmal aufgerufen und dabei werden auch alle aufgerufen. Von
daher kein Problem
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#83?email_source=notifications&email_token=AK3W7LSBRW6B4MAV3XC3YNDRDPI5JA5CNFSM4KVZQHR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCV44PJY#discussion_r380644781>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK3W7LWL6AMX5OR2JAIU6X3RDPI5JANCNFSM4KVZQHRQ>
.
|
Also? |
…ition(), re-add Edge.originPoint, remove RoadShape from ITrack, rename EndPoint.SetWeights() to EndPoint.CalculateRouteProbabilities() This commit has been sponsored by Raid Shadow Legends
Shafma
reviewed
Feb 18, 2020
funketh
requested changes
Feb 19, 2020
There was a problem hiding this comment.
Vorschlag:
- RouteProbabilites wird zu einer einzigen static methode
Choose(destinations, weights)in ner static klasseRandominUtility- (Falls einen der performance verlust juckt, da
CalculateCumulative()quasi unnötig mehrfach berechnet wird, kann man das auch global cachen in nem dictionary von weights zu cumulativeWeights)
- (Falls einen der performance verlust juckt, da
- ==>
EndPoint.CalculateRouteProbabilities()kann komplett weg
funketh
requested changes
Feb 19, 2020
There was a problem hiding this comment.
Vorschlag:
- RouteProbabilites wird zu einer einzigen static methode
Choose(destinations, weights)in ner static klasseRandominUtility- (Falls einen der performance verlust juckt, da
CalculateCumulative()quasi unnötig mehrfach berechnet wird, kann man das auch global cachen in nem dictionary von weights zu cumulativeWeights)
- (Falls einen der performance verlust juckt, da
- ==>
EndPoint.CalculateRouteProbabilities()kann komplett weg
traffic-sim Sprint 2
automation
moved this from Review in progress
to Reviewer approved
Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autos erhalten beim spawnen eine Liste an ITracks, die aus der RoutingTable mit einer gewissen Wahrscheinlichkeit ausgewählt wurde. Die Wahrscheinlichkeit wird durch ein RouteProbability-Objekt kontrolliert. Die RoutingTable besteht aus RouteSegments, die aus einer Edge und einer Lane bestehen.
closes #51