-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
- Loading branch information
There are no files selected for viewing
5 comments
on commit 8ae2b7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to put it in the commit message but this addresses TICKET #184.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for acting on this problem and for the patch! I have applied the patch and then made some further changes. However I don't understand the change on line 794, which doesn't seem to build with GHC HEAD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi David -- Ah, the benefits of code review!
This was sloppy; I must admit I have no idea where that change came from. I didn't intentionally make it. I think it must have been a glitch in my git usage of some kind? Was the changed line from somewhere in the history of the repo?
Otherwise, I must posit that gremlins changed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the extra import had become redundant.
I was going to fix this up but I pulled and noticed you've already overhauled it. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HsClassP is not defined in GHC HEAD, as it seems.