Fix import of atomic shims for GHC 9.10 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Thanks, @bgamari! Obviously, we'll want to want until https://gitlab.haskell.org/ghc/ghc/-/merge_requests/12316 has landed before merging this PR, but the shape of the PR looks great. One minor suggestion inline.
The shims in question are written in Cmm and therefore should be `prim` imports. See GHC #24595.
|
GHC 9.10.1-alpha3 is now out, which includes the changes from https://gitlab.haskell.org/ghc/ghc/-/merge_requests/12316. As such, I think it's safe to land this PR and release it. Thanks again, @bgamari! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shims in question are written in Cmm and therefore should be
primimports.This will require https://gitlab.haskell.org/ghc/ghc/-/merge_requests/12316 as previously
State#was not allowed in the result or argument types of aprimimports.See GHC #24595.