Refactor model #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed meta-data values. This breaks compatibility with the existing LDAP model class. * __basedn__ is now base_dn * __objectclasses__ is now object_classes
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-factored the LDAPConn model class. The new model class inherits now from the ldap3.Entry class, the Attributes from ldap3.Attribute. Hopefully this get me to save Models to the LDAP server.
I changed the value names for model
meta-data:__basedn__is nowbase_dn__objectclasses__is nowobject_classesFeel free to test and provide feedback before I merge this PR to master.