[Fix rubocop#5888] Do not register an offense for headers or env keyw…

…ord args
rrosenblum · May 16, 2018 · cb0b1f3 · cb0b1f3
1 parent 6cdd888
commit cb0b1f3
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Bug fixes
+
+* [#5888](https://github.com/bbatsov/rubocop/issues/5888): Do not register an offense for `headers` or `env` keyword arguments in `Rails/HttpPositionalArguments`. ([@rrosenblum][])
+
 ## 0.56.0 (2018-05-14)
 
 ### New features

diff --git a/lib/rubocop/cop/rails/http_positional_arguments.rb b/lib/rubocop/cop/rails/http_positional_arguments.rb
@@ -22,7 +22,7 @@ class HttpPositionalArguments < Cop
         MSG = 'Use keyword arguments instead of ' \
               'positional arguments for http call: `%<verb>s`.'.freeze
         KEYWORD_ARGS = %i[
-          method params session body flash xhr as
+          method params session body flash xhr as headers env
         ].freeze
         HTTP_METHODS = %i[get post put patch delete head].freeze
 

diff --git a/spec/rubocop/cop/rails/http_positional_arguments_spec.rb b/spec/rubocop/cop/rails/http_positional_arguments_spec.rb
@@ -157,10 +157,16 @@
     end
 
     [
+      'method: :get',
       'params: { user_id: @user.id }',
       'xhr: true',
       'session: { foo: \'bar\' }',
-      'format: :json'
+      'format: :json',
+      'headers: {}',
+      'body: "foo"',
+      'flash: {}',
+      'as: :json',
+      'env: "test"'
     ].each do |keyword_args|
       describe "when using keyword args #{keyword_args}" do
         it 'does not register an offense' do