Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null Safety #200

Closed
DevNico opened this issue Nov 20, 2020 · 8 comments
Closed

Null Safety #200

DevNico opened this issue Nov 20, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@DevNico
Copy link
Contributor

DevNico commented Nov 20, 2020

Null safety is in the second technical preview stage with flutter core support it's therefore time to start migrating packages. I'd be happy to open a PR for Null Safety if it isn't already in the works.

@DevNico DevNico added enhancement New feature or request needs triage labels Nov 20, 2020
@harkairt
Copy link

Any update on this?

@devj3ns
Copy link

devj3ns commented Jan 21, 2021

Hey @DevNico. If you have some free time I would be really happy if you could migrate the Package to null safety or start doing it😀
I wish you a great evening :)

@DevNico
Copy link
Contributor Author

DevNico commented Jan 21, 2021

I actually migrated the package itself but then work and exams came in the way. I have some free time tonight will migrate the tests / example and open a PR.

@DevNico
Copy link
Contributor Author

DevNico commented Jan 22, 2021

PR opened #211.

@derolf
Copy link

derolf commented Jan 25, 2021

@DevNico

Nice work, just trying it out.

But, IMHO, it should be:

final List<Object?>? keys;

not

final List<Object>? keys;

Otherwise it's impossible to pass null as a key, which people quite often do...

@DevNico
Copy link
Contributor Author

DevNico commented Jan 25, 2021

That obviously makes sense I just didn't have this in the codebase I tested with. Will change that when I'm at my Mac later.

@derolf
Copy link

derolf commented Jan 25, 2021

@DevNico I forked your forked and will push a PR in a few minutes...

@DevNico
Copy link
Contributor Author

DevNico commented Jan 28, 2021

A null safe version has been releases.

@DevNico DevNico closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants