Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade json_serializable to 5.0.0 #477

Merged
merged 6 commits into from
Jul 17, 2021
Merged

upgrade json_serializable to 5.0.0 #477

merged 6 commits into from
Jul 17, 2021

Conversation

SunlightBro
Copy link
Contributor

#474
Mentioned in json_serializable CHANGELOG 5.0.0

  • Improve names of private classes generated for toJson and fromJson.
    That's why added why I added:
String get nonPrivateConcreteName {
    return '\$${constructor.redirectedName}';
}

@SunlightBro
Copy link
Contributor Author

SunlightBro commented Jul 16, 2021

I made no changes to prototypes.dart and tear_off.dart.
So I'm not quit sure why this Check format step fails:

Formatted 58 files (2 changed) in 1.76 seconds.
Formatting failed: 1
Error: Process completed with exit code 1.

@SunlightBro
Copy link
Contributor Author

Ok I formatted prototypes.dart and tear_off.dart on the newest flutter dev channel.
I think this happened a few days ago when flutter pushed a new dev pre-release
2.4.0-0.0.pre-dev => 2.4.0-4.0.pre-dev

I also added invalid_annotation_target to the ignore for file, because I didn't see another way around the @Target annotation.

@rrousselGit rrousselGit merged commit 59d147f into rrousselGit:master Jul 17, 2021
@rrousselGit
Copy link
Owner

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants