Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting of lines longer than 80 chars #162

Merged
merged 3 commits into from Jul 19, 2019

Conversation

bradyt
Copy link
Contributor

@bradyt bradyt commented Jul 18, 2019

I wasn't entirely consistent everywhere, but this commit is just a sketch of adding the linter.

Would fix #161.

I could also split out the part about uri missing in widget test, and maybe script a search for typos, and add a full commit for that.

@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #162 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #162   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         581    582    +1     
=====================================
+ Hits          581    582    +1
Impacted Files Coverage Δ
...ges/provider/lib/src/change_notifier_provider.dart 100% <ø> (ø) ⬆️
packages/provider/lib/src/async_provider.dart 100% <ø> (ø) ⬆️
packages/provider/lib/src/provider.dart 100% <ø> (ø) ⬆️
packages/provider/lib/src/listenable_provider.dart 100% <ø> (ø) ⬆️
...es/provider/lib/src/value_listenable_provider.dart 100% <ø> (ø) ⬆️
packages/provider/lib/src/consumer.dart 100% <ø> (ø) ⬆️
packages/provider/example/lib/main.dart 100% <ø> (ø) ⬆️
packages/provider/lib/src/proxy_provider.dart 100% <ø> (ø) ⬆️
packages/provider/lib/src/delegate_widget.dart 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc54992...ff3c1c2. Read the comment docs.

This would be consistent with lines 255-279 of ./provider.dart
@rrousselGit rrousselGit merged commit 20d7665 into rrousselGit:master Jul 19, 2019
@rrousselGit
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long lines in comments
3 participants