Fix some exceptions causing Flutter asking to demangle stacktraces

fixes #1874

packages/flutter_riverpod/pubspec.yaml

@@ -25,3 +25,4 @@ dev_dependencies:
   flutter_test:
     sdk: flutter
   mockito: ^5.0.0
+  stack_trace: ^1.11.1

packages/flutter_riverpod/test/throw_with_stacktrace_test.dart

@@ -0,0 +1,30 @@
+import 'package:flutter/material.dart';
+import 'package:flutter_riverpod/src/internals.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:stack_trace/stack_trace.dart';
+
+void main() {
+  testWidgets('Flutter does not ask to demangle stacktraces', (tester) async {
+    final previousErrorHandler = FlutterError.onError;
+    final stacks = <StackTrace?>[];
+
+    FlutterError.onError = (details) => stacks.add(details.stack);
+    await tester.pumpWidget(
+      MaterialApp(
+        home: Consumer(
+          // ignore: invalid_use_of_internal_member
+          builder: (context, ref, child) => throwErrorWithCombinedStackTrace(
+            StateError('Hello world'),
+            StackTrace.current,
+          ),
+        ),
+      ),
+    );
+    FlutterError.onError = previousErrorHandler;
+
+    expect(
+      stacks,
+      everyElement(isNot(anyOf(isA<Chain>(), isA<Trace>()))),
+    );
+  });
+}

packages/riverpod/CHANGELOG.md

@@ -1,3 +1,7 @@
+## Unreleased patch
+
+- Fix some exceptions causing Flutter asking to demangle stacktraces (#1874)
+
 ## 2.3.7 - 2023-08-16
 
 - Added support for state_notifier 1.0.0

packages/riverpod/lib/src/internals.dart

@@ -15,6 +15,7 @@ export 'notifier.dart';
 export 'provider.dart';
 export 'result.dart';
 export 'run_guarded.dart';
+export 'stack_trace.dart';
 export 'state_notifier_provider.dart';
 export 'state_provider.dart';
 export 'stream_provider.dart';

packages/riverpod/lib/src/stack_trace.dart

@@ -10,5 +10,5 @@ Never throwErrorWithCombinedStackTrace(Object error, StackTrace stackTrace) {
     ...Chain.forTrace(stackTrace).traces,
   ]).foldFrames((frame) => frame.package == 'riverpod');
 
-  Error.throwWithStackTrace(error, chain);
+  Error.throwWithStackTrace(error, chain.toTrace().vmTrace);
 }