Updated counter example to the new @riverpod syntax #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2247 +/- ##
=======================================
Coverage 95.24% 95.24%
=======================================
Files 53 53
Lines 2250 2250
=======================================
Hits 2143 2143
Misses 107 107 |
rrousselGit
reviewed
Mar 2, 2023
examples/counter/lib/main.dart
Outdated
| @@ -20,7 +23,13 @@ class MyApp extends StatelessWidget { | |||
| } | |||
|
|
|||
| /// Providers are declared globally and specify how to create a state | |||
There was a problem hiding this comment.
The comments need to be reviewed to match the codegen syntax.
"declared globally" is more about how providers where final global variables. But here it's a class, nothing special.
On the other hand people may want to know what that class means. In particular the build method
There was a problem hiding this comment.
Does it really matter, since the author recently said this 😇
More seriously, I have updated the comments in the file.
There was a problem hiding this comment.
Hum not fond of them still. I'll update them to my liking, give me a minute.
rrousselGit
approved these changes
Mar 2, 2023
|
Alright~ I'll wait for the CI to pass and merge this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced StateProvider with a provider created with @riverpod