Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion assists for various widgets, including Hook-based widgets #2306

Merged
merged 30 commits into from Apr 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
cd7f967
enable riverpod_lint
K9i-0 Mar 12, 2023
b4fea06
remove unnecessary Consumer
K9i-0 Mar 12, 2023
42f6739
move field
K9i-0 Mar 12, 2023
40f6379
add convert to widget assists
K9i-0 Mar 12, 2023
c8b2e46
implement ConvertToStatelessWidget
K9i-0 Mar 12, 2023
2024145
implement ConvertToStatefulWidget
K9i-0 Mar 12, 2023
38dfc92
fix file name
K9i-0 Mar 12, 2023
6e67631
add current test result
K9i-0 Mar 12, 2023
e08805d
Merge branch 'master' into add_new_lints
K9i-0 Mar 14, 2023
ee9bae7
Implement ConvertToStatefulHookWidget's method
K9i-0 Mar 17, 2023
3ed6c52
Implement ConvertToStatefulHookConsumerWidget's method
K9i-0 Mar 17, 2023
ec624b2
Implement ConvertToHookWidget's method
K9i-0 Mar 17, 2023
6cac1ac
Implement ConvertToHookConsumerWidget's method
K9i-0 Mar 17, 2023
feff63e
Add test
K9i-0 Mar 21, 2023
a29515c
Refactor
K9i-0 Mar 21, 2023
177eda9
remove
K9i-0 Mar 21, 2023
f23df4c
Merge branch 'master' into add_new_lints
K9i-0 Apr 7, 2023
74524df
Display hook-related assists only when there is a dependency on hooks…
K9i-0 Apr 8, 2023
5e50047
Change priorities
K9i-0 Apr 8, 2023
02b77fa
update golden files
K9i-0 Apr 8, 2023
f8f4597
change test file name
K9i-0 Apr 8, 2023
5eb0935
Provide assists for hook-related functions only when there is a depen…
K9i-0 Apr 8, 2023
a224e24
change name
K9i-0 Apr 8, 2023
d9d8a34
Merge branch 'master' of https://github.com/rrousselGit/riverpod into…
rrousselGit Apr 8, 2023
1929cba
Remove dynamic
rrousselGit Apr 8, 2023
0c12926
Update packages/riverpod_lint_flutter_test/test/assists/convert_to_wi…
rrousselGit Apr 8, 2023
c38f878
Use named parameters
K9i-0 Apr 8, 2023
94e67f0
Refactor
rrousselGit Apr 8, 2023
b2c8fb9
Merge branch 'add_new_lints' of https://github.com/k9i-0/riverpod int…
rrousselGit Apr 8, 2023
3975a36
Changelog
rrousselGit Apr 8, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/riverpod_lint/CHANGELOG.md
@@ -1,3 +1,7 @@
## Unreleased minor

- Added assists for converting widgets to HookWidget/HookConsumerWidget (thanks to @K9i-0)

## 1.1.8 - 2023-04-07

- Disable unsupported_provider_value when a notifier returns "this"
Expand Down
17 changes: 13 additions & 4 deletions packages/riverpod_lint/lib/riverpod_lint.dart
@@ -1,7 +1,8 @@
import 'package:custom_lint_builder/custom_lint_builder.dart';

import 'src/assists/convert_to_consumer_stateful_widget.dart';
import 'src/assists/convert_to_consumer_widget.dart';
import 'src/assists/convert_to_stateful_base_widget.dart';
import 'src/assists/convert_to_stateless_base_widget.dart';
import 'src/assists/convert_to_widget_utils.dart';
import 'src/assists/stateful_to_stateless_provider.dart';
import 'src/assists/stateless_to_stateful_provider.dart';
import 'src/assists/wrap_with_consumer.dart';
Expand Down Expand Up @@ -56,8 +57,16 @@ class _RiverpodPlugin extends PluginBase {
List<Assist> getAssists() => [
WrapWithConsumer(),
WrapWithProviderScope(),
ConvertToConsumerWidget(),
ConvertToConsumerStatefulWidget(),
...StatelessBaseWidgetType.values.map(
(targetWidget) => ConvertToStatelessBaseWidget(
targetWidget: targetWidget,
),
),
...StatefulBaseWidgetType.values.map(
(targetWidget) => ConvertToStatefulBaseWidget(
targetWidget: targetWidget,
),
),

// StateProvider to SyncStatefulProvider
// convert FutureProvider <> AsyncNotifierProvider
Expand Down
202 changes: 0 additions & 202 deletions packages/riverpod_lint/lib/src/assists/convert_to_consumer_widget.dart

This file was deleted.