Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix provider_dependencies not considering dependencies inside methods other than build of a notifier. #2435

Merged
merged 1 commit into from
Apr 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/riverpod_analyzer_utils/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## Unreleased fix

- Handle cascade operators in ref expressions
- Fix ref.watch/read/... not being decoded inside Notifier methods of generated providers.

## 0.2.0 - 2023-03-13

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ class StatefulProviderDeclaration extends GeneratorProviderDeclaration {
valueType: _getValueType(createdType),
);
riverpodAnnotation._parent = statefulProviderDeclaration;
buildMethod.accept(
node.accept(
_GeneratorRefInvocationVisitor(statefulProviderDeclaration, parent),
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,44 @@ final dependency = Provider((ref) {
expect(result.refWatchInvocations.single.provider.providerElement, null);
});

testSource('Decodes ref expressions in Notifier methods',
runGenerator: true, source: r'''
import 'package:riverpod/riverpod.dart';
import 'package:riverpod_annotation/riverpod_annotation.dart';

part 'foo.g.dart';

@riverpod
class MyNotifier extends _$MyNotifier {
@override
int build() => 0;

void method() {
ref.watch(generatedScopedProvider);
}
}

''', (resolver) async {
// Regression test for https://github.com/rrousselGit/riverpod/issues/2417
final result = await resolver.resolveRiverpodAnalyssiResult();

final notifier = result.statefulProviderDeclarations.single;

expect(result.refInvocations, hasLength(1));
expect(
result.refWatchInvocations.single.provider.node.toSource(),
'generatedScopedProvider',
);
expect(
notifier.refInvocations.single,
isA<RefWatchInvocation>().having(
(e) => e.provider.node.toSource(),
'provider',
'generatedScopedProvider',
),
);
});

testSource('Decodes ..watch', runGenerator: true, source: r'''
import 'package:riverpod/riverpod.dart';
import 'package:riverpod_annotation/riverpod_annotation.dart';
Expand Down
2 changes: 2 additions & 0 deletions packages/riverpod_lint/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
- Disable unsupported_provider_value when a notifier returns "this"
- Fix scoped_providers_should_specify_dependencies incorrectly triggering on functions other than "main"
- Handle cascade operators in ref expressions
- Fix `provider_dependencies` not considering dependencies inside methods
other than `build` of a notifier.

## 1.1.7 - 2023-04-06

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,3 +175,13 @@ int regression2348(Regression2348Ref ref) {
ref..watch(generatedScopedProvider);
return 0;
}

@Riverpod(dependencies: [generatedScoped])
class Regression2417 extends _$Regression2417 {
@override
int build() => 0;

void method() {
ref.watch(generatedScopedProvider);
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.