[riverpod_generator] Add provider_name_prefix and provider_family_name_prefix to build.yaml
#3348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3348 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 53 53
Lines 2298 2298
=======================================
Hits 2187 2187
Misses 111 111 |
ValentinVignal
force-pushed
the
riverpod-generator/Add-provider-prefix-to-config
branch
from
2f74038
to
19e0f49
Compare
|
@rrousselGit I see some of the tests are timing out. Is it because of my changes? |
|
No don't worry about those tests. |
| # providers with parameters ("families"). | ||
| # This takes precedence over provider_name_suffix. | ||
| provider_family_name_suffix: "Provider" # (default) | ||
| ``` | ||
|
|
||
| You can change provider name prefix in the build.yaml file: | ||
|
|
||
| ```yaml |
There was a problem hiding this comment.
I don't think this warrants a separate code snippet. I'd fuse the doc for prefixes and suffixes
There was a problem hiding this comment.
I fused them in doc: Fuse the doc for prefixes and suffixes
| @@ -30,6 +36,13 @@ extension CaseChangeExtension on String { | |||
| ); | |||
| } | |||
|
|
|||
| String get upperFirst { | |||
There was a problem hiding this comment.
There's a string.titled extension already.
There was a problem hiding this comment.
I removed it in refactor: Use titled instead of upperFirst
Sure ! Does that mean you want us to merge this in
|
|
Please create two PRs. One on |
Okay understood! I've applied the requested changes to this PR. When merged, I'll work on creating another PR to merge |
|
I'd prefer if you could raise that PR about merging to dev before merging this PR. This way I can merge both at once I'd like to avoid |
|
Sure, I'll do that |
|
@rrousselGit I made the PR on |
|
LGTM, thanks! |
Related Issues
fixes #3189
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).I have updated the
CHANGELOG.mdof the relevant packages.Changelog files must be edited under the form:
If this contains new features or behavior changes,
I have updated the documentation to match those changes.