closes #20

rrousselGit · Jun 4, 2020 · b5cc1c2 · b5cc1c2
1 parent ccd2736
commit b5cc1c2
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 3 deletions.
diff --git a/packages/state_notifier/CHANGELOG.md b/packages/state_notifier/CHANGELOG.md
@@ -1,3 +1,7 @@
+## [0.5.0] - 4/06/2020
+
+If no `onError` is specified, errors are now reported to the current `Zone`.
+
 ## [0.4.0] - 13/03/2020
 
 Added a flag on `addListener` to disable the first immediate call of the listener

diff --git a/packages/state_notifier/lib/state_notifier.dart b/packages/state_notifier/lib/state_notifier.dart
@@ -1,5 +1,6 @@
 library state_notifier;
 
+import 'dart:async';
 import 'dart:collection';
 
 import 'package:meta/meta.dart';
@@ -152,9 +153,13 @@ Consider checking `mounted`.
     for (final listenerEntry in _listeners) {
       try {
         listenerEntry.listener(value);
-      } catch (err, stack) {
+      } catch (error, stackTrace) {
         didThrow = true;
-        onError?.call(err, stack);
+        if (onError != null) {
+          onError(error, stackTrace);
+        } else {
+          Zone.current.handleUncaughtError(error, stackTrace);
+        }
       }
     }
     if (didThrow) {

diff --git a/packages/state_notifier/pubspec.yaml b/packages/state_notifier/pubspec.yaml
@@ -1,6 +1,6 @@
 name: state_notifier
 description: ValueNotifier, but outside Flutter and with some extra perks
-version: 0.4.0
+version: 0.5.0
 author: Remi Rousselet <darky12s@gmail.com>
 homepage: https://github.com/rrousselGit/state_notifier
 

diff --git a/packages/state_notifier/test/state_notifier_test.dart b/packages/state_notifier/test/state_notifier_test.dart
@@ -1,3 +1,5 @@
+import 'dart:async';
+
 import 'package:mockito/mockito.dart';
 import 'package:test/test.dart';
 
@@ -222,6 +224,24 @@ void main() {
     verify(onError(error, argThat(isNotNull))).called(1);
     verifyNoMoreInteractions(onError);
   });
+  test('no onError fallbacks to zone', () {
+    final notifier = TestNotifier(0)
+      ..addListener((v) {
+        if (v > 0) throw StateError('first');
+      })
+      ..addListener((v) {
+        if (v > 0) throw StateError('second');
+      });
+
+    final errors = <Object>[];
+    runZonedGuarded(notifier.increment, (err, stack) => errors.add(err));
+
+    expect(errors, [
+      isStateError.having((s) => s.message, 'message', 'first'),
+      isStateError.having((s) => s.message, 'message', 'second'),
+      isA<Error>(),
+    ]);
+  });
   test('onError (change)', () {
     final onError = ErrorListener();
     final notifier = TestNotifier(0)