Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on git #17

Closed
Nepoxx opened this issue Apr 6, 2017 · 2 comments
Closed

Dependency on git #17

Nepoxx opened this issue Apr 6, 2017 · 2 comments

Comments

@Nepoxx
Copy link
Contributor

Nepoxx commented Apr 6, 2017

This project assumes that it is running in a git folder, I'm looking for a suggestion on how to remove that.
Right now, in webpack.dev.config.js , replacing:

'GIT_REVISION': '\"potato\"',

is a working workaround (the escaped quotes are required since the value is interpreted as-in (which seems bad)), but is hackish at best.

@rroylance
Copy link
Owner

rroylance commented Apr 6, 2017

You should just need to delete the GIT_REVISION part from define plugin (where you set it to potato, just delete that line) and then remove any occurence of GIT_REVISION from the code (I believe it's only used in one place in a console log). It doesn't actually require the use of git or anything so you'll be fine to get rid of that. You can also get rid of the git revision plugin as it will no longer be needed.

@rroylance
Copy link
Owner

Considering this solved. Closing.

rroylance added a commit that referenced this issue Apr 26, 2017
- Properly closes #17; removed git dependence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants