-
Notifications
You must be signed in to change notification settings - Fork 416
/
function_names.ex
188 lines (157 loc) · 5.35 KB
/
function_names.ex
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
defmodule Credo.Check.Readability.FunctionNames do
use Credo.Check,
id: "EX3004",
base_priority: :high,
param_defaults: [
allow_acronyms: false
],
explanations: [
check: """
Function, macro, and guard names are always written in snake_case in Elixir.
# snake_case
def handle_incoming_message(message) do
end
# not snake_case
def handleIncomingMessage(message) do
end
Like all `Readability` issues, this one is not a technical concern.
But you can improve the odds of others reading and liking your code by making
it easier to follow.
""",
params: [
allow_acronyms: "Allows acronyms like HTTP or OTP in function names."
]
]
alias Credo.Code.Name
@def_ops [:def, :defp, :defmacro, :defmacrop, :defguard, :defguardp]
@all_sigil_chars ~w(a A b B c C d D e E f F g G h H i I j J k K l L m M n N o O p P q Q r R s S t T u U v V w W x X y Y z Z)
@all_sigil_atoms Enum.map(@all_sigil_chars, &:"sigil_#{&1}")
# all non-special-form operators
@all_nonspecial_operators ~W(! && ++ -- .. <> =~ @ |> || != !== * + - / < <= == === > >= ||| &&& <<< >>> <<~ ~>> <~ ~> <~> <|> ^^^ ~~~ +++ ---)a
@doc false
@impl true
def run(%SourceFile{} = source_file, params \\ []) do
issue_meta = IssueMeta.for(source_file, params)
allow_acronyms? = Credo.Check.Params.get(params, :allow_acronyms, __MODULE__)
source_file
|> Credo.Code.prewalk(&traverse(&1, &2, issue_meta, allow_acronyms?), empty_issues())
|> issues_list()
end
defp empty_issues, do: %{}
defp add_issue(issues, name, arity, issue), do: Map.put_new(issues, {name, arity}, issue)
defp issues_list(issues) do
issues
|> Map.values()
|> Enum.sort_by(& &1.line_no)
end
# Ignore sigil definitions
for sigil <- @all_sigil_atoms do
defp traverse(
{op, _meta, [{unquote(sigil), _sigil_meta, _args} | _tail]} = ast,
issues,
_issue_meta,
_allow_acronyms?
)
when op in [:def, :defmacro] do
{ast, issues}
end
defp traverse(
{op, _op_meta,
[{:when, _when_meta, [{unquote(sigil), _sigil_meta, _args} | _tail]}, _block]} = ast,
issues,
_issue_meta,
_allow_acronyms?
)
when op in [:def, :defmacro] do
{ast, issues}
end
end
# NOTE: see above for how we want to avoid `sigil_X` definitions
for op <- @def_ops do
# Ignore variables named e.g. `defp`
defp traverse({unquote(op), _meta, nil} = ast, issues, _issue_meta, _allow_acronyms?) do
{ast, issues}
end
# ignore non-special-form (overridable) operators
defp traverse(
{unquote(op), _meta, [{operator, _at_meta, _args} | _tail]} = ast,
issues,
_issue_meta,
_allow_acronyms?
)
when operator in @all_nonspecial_operators do
{ast, issues}
end
# ignore non-special-form (overridable) operators
defp traverse(
{unquote(op), _meta,
[
{:when, _,
[
{operator, _, _} | _
]}
| _
]} = ast,
issues,
_issue_meta,
_allow_acronyms?
)
when operator in @all_nonspecial_operators do
{ast, issues}
end
defp traverse({unquote(op), _meta, arguments} = ast, issues, issue_meta, allow_acronyms?) do
{ast, issues_for_definition(arguments, issues, issue_meta, allow_acronyms?)}
end
end
defp traverse(ast, issues, _issue_meta, _allow_acronyms?) do
{ast, issues}
end
defp issues_for_definition(
[{:when, _when_meta, [{name, meta, args} | _guard]} | _],
issues,
issue_meta,
allow_acronyms?
) do
issues_for_name(name, args, meta, issues, issue_meta, allow_acronyms?)
end
defp issues_for_definition([{name, meta, args} | _], issues, issue_meta, allow_acronyms?)
when is_atom(name) do
issues_for_name(name, args, meta, issues, issue_meta, allow_acronyms?)
end
defp issues_for_definition(_body, issues, _issue_meta, _allow_acronyms?) do
issues
end
defp issues_for_name({:unquote, _, _}, _args, _meta, issues, _issue_meta, _allow_acronyms?) do
issues
end
defp issues_for_name("sigil_" <> sigil_letters = name, args, meta, issues, issue_meta, _allow_acronyms?) do
multi_letter_sigil? = String.match?(sigil_letters, ~r/^[A-Z]+$/)
if multi_letter_sigil? do
issues
else
issue = issue_for(issue_meta, meta[:line], name)
arity = length(args || [])
add_issue(issues, name, arity, issue)
end
end
defp issues_for_name("" <> name, args, meta, issues, issue_meta, allow_acronyms?) do
if Name.snake_case?(name, allow_acronyms?) do
issues
else
issue = issue_for(issue_meta, meta[:line], name)
arity = length(args || [])
add_issue(issues, name, arity, issue)
end
end
defp issues_for_name(name, args, meta, issues, issue_meta, allow_acronyms?) do
name |> to_string |> issues_for_name(args, meta, issues, issue_meta, allow_acronyms?)
end
defp issue_for(issue_meta, line_no, trigger) do
format_issue(
issue_meta,
message: "Function/macro/guard names should be written in snake_case.",
trigger: trigger,
line_no: line_no
)
end
end