-
Notifications
You must be signed in to change notification settings - Fork 416
/
duplicated_code.ex
272 lines (222 loc) · 7.45 KB
/
duplicated_code.ex
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
defmodule Credo.Check.Design.DuplicatedCode do
@moduledoc false
@checkdoc """
Code should not be copy-pasted in a codebase when there is room to abstract
the copied functionality in a meaningful way.
That said, you should by no means "ABSTRACT ALL THE THINGS!".
Sometimes it can serve a purpose to have code be explicit in two places, even
if it means the snippets are nearly identical. A good example for this are
Database Adapters in a project like Ecto, where you might have nearly
identical functions for things like `order_by` or `limit` in both the
Postgres and MySQL adapters.
In this case, introducing an `AbstractAdapter` just to avoid code duplication
might cause more trouble down the line than having a bit of duplicated code.
Like all `Software Design` issues, this is just advice and might not be
applicable to your project/situation.
"""
@explanation [
check: @checkdoc,
params: [
mass_threshold:
"The minimum mass which a part of code has to have to qualify for this check.",
nodes_threshold: "The number of nodes that need to be found to raise an issue.",
excluded_macros: "List of macros to be excluded for this check."
]
]
@default_params [
mass_threshold: 40,
nodes_threshold: 2,
excluded_macros: []
]
use Credo.Check, run_on_all: true, base_priority: :higher
alias Credo.SourceFile
@doc false
def run(source_files, exec, params \\ []) when is_list(source_files) do
mass_threshold = Params.get(params, :mass_threshold, __MODULE__)
nodes_threshold = Params.get(params, :nodes_threshold, __MODULE__)
source_files
|> duplicate_nodes(mass_threshold)
|> append_issues_via_issue_service(source_files, nodes_threshold, params, exec)
:ok
end
defp append_issues_via_issue_service(found_hashes, source_files, nodes_threshold, params, exec)
when is_map(found_hashes) do
Enum.each(found_hashes, fn {_hash, nodes} ->
filenames = Enum.map(nodes, & &1.filename)
Enum.each(
source_files,
&new_issue_for_members(filenames, &1, nodes_threshold, nodes, params, exec)
)
end)
end
defp new_issue_for_members(filenames, source_file, nodes_threshold, nodes, params, exec) do
if Enum.member?(filenames, source_file.filename) do
this_node = Enum.find(nodes, &(&1.filename == source_file.filename))
other_nodes = List.delete(nodes, this_node)
issue_meta = IssueMeta.for(source_file, params)
issue = issue_for(issue_meta, this_node, other_nodes, nodes_threshold, params)
if issue do
Credo.Execution.ExecutionIssues.append(exec, source_file, issue)
end
end
end
defp duplicate_nodes(source_files, mass_threshold) do
source_files
|> Enum.reduce(%{}, fn source_file, acc ->
ast = SourceFile.ast(source_file)
calculate_hashes(ast, acc, source_file.filename, mass_threshold)
end)
|> prune_hashes
|> add_masses
end
def add_masses(found_hashes) do
Enum.into(found_hashes, %{}, &add_mass_to_subnode/1)
end
defp add_mass_to_subnode({hash, node_items}) do
node_items =
Enum.map(node_items, fn node_item ->
%{node_item | mass: mass(node_item.node)}
end)
{hash, node_items}
end
@doc """
Takes a map of hashes to nodes and prunes those nodes that are just
subnodes of others in the same set.
Returns the resulting map.
"""
def prune_hashes(
given_hashes,
mass_threshold \\ @default_params[:mass_threshold]
) do
# remove entries containing a single node
hashes_with_multiple_nodes =
given_hashes
|> Enum.filter(fn {_hash, node_items} -> Enum.count(node_items) > 1 end)
|> Enum.into(%{})
hashes_to_prune =
Enum.flat_map(
hashes_with_multiple_nodes,
&collect_subhashes(&1, mass_threshold)
)
delete_keys(hashes_to_prune, hashes_with_multiple_nodes)
end
defp delete_keys([], acc), do: acc
defp delete_keys([head | tail], acc) do
delete_keys(tail, Map.delete(acc, head))
end
defp collect_subhashes({_hash, node_items}, mass_threshold) do
%{node: first_node, filename: filename} = Enum.at(node_items, 0)
my_hash = first_node |> Credo.Code.remove_metadata() |> to_hash
# don't count self
subhashes =
first_node
|> calculate_hashes(%{}, filename, mass_threshold)
|> Map.keys()
|> List.delete(my_hash)
subhashes
end
@doc """
Calculates hash values for all sub nodes in a given +ast+.
Returns a map with the hashes as keys and the nodes as values.
"""
def calculate_hashes(
ast,
existing_hashes \\ %{},
filename \\ "foo.ex",
mass_threshold \\ @default_params[:mass_threshold]
)
when is_map(existing_hashes) do
Credo.Code.prewalk(
ast,
&collect_hashes(&1, &2, filename, mass_threshold),
existing_hashes
)
end
defp collect_hashes(ast, acc, filename, mass_threshold) do
if mass(ast) < mass_threshold do
{ast, acc}
else
hash = ast |> Credo.Code.remove_metadata() |> to_hash
node_item = %{node: ast, filename: filename, mass: nil}
node_items = Map.get(acc, hash, [])
acc = Map.put(acc, hash, node_items ++ [node_item])
{ast, acc}
end
end
@doc """
Returns a hash-value for a given +ast+.
"""
def to_hash(ast) do
string =
ast
|> Inspect.Algebra.to_doc(%Inspect.Opts{})
|> Inspect.Algebra.format(80)
|> Enum.join("")
:sha256
|> :crypto.hash(string)
|> Base.encode16()
end
@doc """
Returns the mass (count of instructions) for an AST.
"""
def mass(ast) do
Credo.Code.prewalk(ast, &calc_mass/2, 0)
end
defp calc_mass(ast, acc) when is_tuple(ast) do
{ast, acc + 1}
end
defp calc_mass(ast, acc) do
{ast, acc}
end
defp issue_for(issue_meta, this_node, other_nodes, nodes_threshold, params) do
if Enum.count(other_nodes) >= nodes_threshold - 1 do
filenames =
other_nodes
|> Enum.map(fn other_node ->
"#{other_node.filename}:#{line_no_for(other_node.node)}"
end)
|> Enum.join(", ")
node_mass = this_node.mass
line_no = line_no_for(this_node.node)
excluded_macros = params[:excluded_macros] || []
if create_issue?(this_node.node, excluded_macros) do
format_issue(
issue_meta,
message: "Duplicate code found in #{filenames} (mass: #{node_mass}).",
line_no: line_no,
severity: Severity.compute(1 + Enum.count(other_nodes), 1)
)
end
end
end
# ignore similar module attributes, no matter how complex
def create_issue?({:@, _, _}, _), do: false
def create_issue?([do: {atom, _, arguments}], excluded_macros)
when is_atom(atom) and is_list(arguments) do
!Enum.member?(excluded_macros, atom)
end
def create_issue?({atom, _, arguments}, excluded_macros)
when is_atom(atom) and is_list(arguments) do
!Enum.member?(excluded_macros, atom)
end
def create_issue?(_ast, _), do: true
# TODO: Put in AST helper
def line_no_for({:__block__, _meta, arguments}) do
line_no_for(arguments)
end
def line_no_for({:do, arguments}) do
line_no_for(arguments)
end
def line_no_for({atom, meta, _}) when is_atom(atom) do
meta[:line]
end
def line_no_for(list) when is_list(list) do
Enum.find_value(list, &line_no_for/1)
end
def line_no_for(nil), do: nil
def line_no_for(block) do
block
|> Credo.Code.Block.do_block_for!()
|> line_no_for
end
end