Rename module attribute

rrrene · May 2, 2024 · 450f9e9 · 450f9e9
1 parent d8011ee
commit 450f9e9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/lib/credo/check/warning/leaky_environment.ex b/lib/credo/check/warning/leaky_environment.ex
@@ -27,7 +27,7 @@ defmodule Credo.Check.Warning.LeakyEnvironment do
     Credo.Code.prewalk(source_file, &traverse(&1, &2, issue_meta))
   end
 
-  @offset 2
+  @colon_and_dot_length 2
   defp traverse({{:., _, call}, meta, args} = ast, issues, issue_meta) do
     case get_forbidden_call(call, args) do
       nil ->
@@ -39,7 +39,7 @@ defmodule Credo.Check.Warning.LeakyEnvironment do
       trigger ->
         [module, _function] = call
         len = module |> Atom.to_string() |> String.length()
-        column = meta[:column] - len - @offset
+        column = meta[:column] - len - @colon_and_dot_length
         meta = Keyword.put(meta, :column, column)
 
         {ast, [issue_for(issue_meta, meta, trigger) | issues]}

diff --git a/lib/credo/check/warning/unsafe_exec.ex b/lib/credo/check/warning/unsafe_exec.ex
@@ -66,11 +66,10 @@ defmodule Credo.Check.Warning.UnsafeExec do
     nil
   end
 
-  # offset 2 characters for the dot call and the atom syntax
-  @offset 2
+  @colon_and_dot_length 2
   defp issue_for(call, suggestion, trigger, meta, module, issue_meta) do
     len = module |> Atom.to_string() |> String.length()
-    column = meta[:column] - len - @offset
+    column = meta[:column] - len - @colon_and_dot_length
 
     format_issue(issue_meta,
       message: "Prefer #{suggestion} over #{call} to prevent command injection.",