Fixing issue #866 to check predicates with arity

rrrene · Jul 18, 2021 · d9474a1 · d9474a1
1 parent db252cc
commit d9474a1
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/credo/check/readability/predicate_function_names.ex b/lib/credo/check/readability/predicate_function_names.ex
@@ -77,7 +77,7 @@ defmodule Credo.Check.Readability.PredicateFunctionNames do
 
   defp issues_for_definition(op, body, issues, issue_meta) do
     case Enum.at(body, 0) do
-      {name, meta, nil} ->
+      {name, meta, _} ->
         issues_for_name(op, name, meta, issues, issue_meta)
 
       _ ->

diff --git a/test/credo/check/readability/predicate_function_names_test.exs b/test/credo/check/readability/predicate_function_names_test.exs
@@ -44,4 +44,24 @@ defmodule Credo.Check.Readability.PredicateFunctionNamesTest do
     |> run_check(@described_check)
     |> assert_issues()
   end
+
+  test "it should report a violation with arity" do
+    """
+    def is_valid?(a) do
+    end
+    """
+    |> to_source_file
+    |> run_check(@described_check)
+    |> assert_issue()
+  end
+
+  test "it should report a violation with arity /2" do
+    """
+    def is_valid(a) do
+    end
+    """
+    |> to_source_file
+    |> run_check(@described_check)
+    |> assert_issue()
+  end
 end