Fix :files/:included param for checks

This was a bug, where when no files where found for a set param then all files would be used.
rrrene · Jan 30, 2024 · f1c7695 · f1c7695
1 parent cf88086
commit f1c7695
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/credo/check/runner.ex b/lib/credo/check/runner.ex
@@ -61,6 +61,10 @@ defmodule Credo.Check.Runner do
           exec
           |> Execution.working_dir()
           |> Credo.Sources.find_in_dir(files_included, files_excluded)
+          |> case do
+            [] -> :skip_run
+            files -> files
+          end
       end
 
     source_files =

diff --git a/lib/credo/check/warning/wrong_test_file_extension.ex b/lib/credo/check/warning/wrong_test_file_extension.ex
@@ -3,7 +3,7 @@ defmodule Credo.Check.Warning.WrongTestFileExtension do
     id: "EX5025",
     base_priority: :high,
     param_defaults: [
-      files: %{included: ["test/**/*_test.exs"]}
+      files: %{included: ["test/**/*_test.ex"]}
     ],
     explanations: [
       check: """
@@ -12,7 +12,7 @@ defmodule Credo.Check.Warning.WrongTestFileExtension do
 
       (from the `ex_unit` docs)
 
-      This check ensures that test files are not ending with `.ex` (which would cause them to be skipped).
+      This check ensures that test files are not ending with `_test.ex` (which would cause them to be skipped).
       """
     ]