Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return persistent homology as data frame instead of matrix #11

Closed
rrrlw opened this issue Jan 23, 2019 · 1 comment
Closed

Return persistent homology as data frame instead of matrix #11

rrrlw opened this issue Jan 23, 2019 · 1 comment
Assignees
@rrrlw
Labels
enhancement New feature or request

Comments

@rrrlw
Copy link
Owner

rrrlw commented Jan 23, 2019

Data frames are better for visualization (using the grammar of graphics system in ggplot2); should be a quick switch to return as a data frame instead of matrix.
@rrrlw rrrlw added the enhancement New feature or request label Jan 23, 2019
@rrrlw rrrlw self-assigned this Jan 23, 2019
rrrlw added a commit that referenced this issue Jan 23, 2019
@rrrlw
Addresses #11; add optional parameter to calculate_homology
36cb1de
@rrrlw
Copy link
Owner Author

rrrlw commented Jan 23, 2019

Added an optional parameter to calculate_homology (named return_df) that users can change to either return a matrix or a data frame

@rrrlw rrrlw closed this as completed Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrrlw rrrlw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rrrlw