Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Injected styles are cleared when node is added to a <style> element #1460

Open
1 task done
billyvg opened this issue Apr 24, 2024 · 1 comment
Open
1 task done
Labels
bug Something isn't working

Comments

@billyvg
Copy link
Contributor

billyvg commented Apr 24, 2024

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

v2.0.0-alpha.13

Expected Behavior

Injected styles (block styles, noscript) should remain on the document during playback.

Actual Behavior

Injected styles are being lost when we have a mutation that adds a node to a style element and there is a fast forward event.

Steps to Reproduce

I've wrote up a test case here: #1459

Testcase Gist URL

No response

Additional Information

No response

@billyvg billyvg added the bug Something isn't working label Apr 24, 2024
@jaj1014
Copy link

jaj1014 commented May 23, 2024

This sounds like the bug I reported and have a PR up for. #1357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants