Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: progress bar not updating when adding event asynchronously using addEvent #1492

Open
1 task done
ShayMalchi opened this issue Jun 4, 2024 · 0 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@ShayMalchi
Copy link

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

^2.0.0-alpha.11

Expected Behavior

Seeing the progress bar getting compacted (specifically inactive time) as duration grows, as well as custom events in the right timing.

Actual Behavior

calling addEvent updates the duration, but not redraws the progress bar. The progress bar drawing remains like the original, specifically inactive time doesn't "compress" as it should and custom events are not showing on the right place in the bar.

Steps to Reproduce

  1. Init a player using new rrwebPlayer(...) (with or without liveMode, didn't see the difference)
  2. add events asynchronously after some time.
  3. See the progress bar hasn't updated, but duration did.
  4. do a full reload and see the progress bar is updated.

Testcase Gist URL

No response

Additional Information

No response

@ShayMalchi ShayMalchi added the bug Something isn't working label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant