Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Tidy up some dependencies and tests #373

Merged
merged 5 commits into from Sep 15, 2020
Merged

Tidy up some dependencies and tests #373

merged 5 commits into from Sep 15, 2020

Conversation

ljedrz
Copy link
Member

@ljedrz ljedrz commented Sep 15, 2020

No functional changes, just quality of life / developer experience ones plus a small dependency update.

As always, the commits describe the specific changes.

@ljedrz
chore: tidy up the dependencies in lib.rs
9edb9cf 
Signed-off-by: ljedrz <ljedrz@gmail.com>
@ljedrz
feat: rename spawn_connected_nodes to spawn_nodes and add a somewhat …
c5eca0e 
…obvious Topology::None

Signed-off-by: ljedrz <ljedrz@gmail.com>
@ljedrz
refactor: make the DHT tests more compact
386d4c0 
Signed-off-by: ljedrz <ljedrz@gmail.com>
@ljedrz
chore: rename start_nodes_in_chain to spawn_bootstrapped_nodes
31d6582 
Signed-off-by: ljedrz <ljedrz@gmail.com>
@ljedrz
chore: cargo update
922dede 
Signed-off-by: ljedrz <ljedrz@gmail.com>
aphelionz
aphelionz approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@aphelionz aphelionz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

bors r+

bors bot added a commit that referenced this pull request Sep 15, 2020
@bors @ljedrz
Merge #373
875add3 
373: Tidy up some dependencies and tests r=aphelionz a=ljedrz

No functional changes, just quality of life / developer experience ones plus a small dependency update.

As always, the commits describe the specific changes.

Co-authored-by: ljedrz <ljedrz@gmail.com>
@ljedrz
Copy link
Member Author

ljedrz commented Sep 15, 2020

tests::kademlia::dht_providing seems to have failed when running in go-ipfs interop mode; can't reproduce locally and those tests are still pretty fresh, so perhaps it's a random glitch?
bors retry

@bors
Copy link
Contributor

bors bot commented Sep 15, 2020

Already running a review

@ljedrz
Copy link
Member Author

ljedrz commented Sep 15, 2020 •
edited

I will have my way 😃
bors retry

@bors
Copy link
Contributor

bors bot commented Sep 15, 2020

Already running a review

@ljedrz
Copy link
Member Author

ljedrz commented Sep 15, 2020

oh, so cancelling jobs doesn't cancel bors?
bors r-

@bors
Copy link
Contributor

bors bot commented Sep 15, 2020

Canceled.

@ljedrz
Copy link
Member Author

ljedrz commented Sep 15, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 15, 2020

Build succeeded:

@bors bors bot merged commit 070abe5 into rs-ipfs:master Sep 15, 2020
@ljedrz ljedrz deleted the test_and_dep_tweaks branch September 15, 2020 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aphelionz aphelionz aphelionz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ljedrz @aphelionz