Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

switch license from isc to mit/apl2.0 #50

Merged
merged 1 commit into from Feb 23, 2020
Merged

Conversation

koivunej
Copy link
Collaborator

@koivunej koivunej commented Feb 20, 2020

I'll be following up with PRs to other repos. Changes:

I'll still need to check that the readme links work as I didn't copy those for some reason :)

I am requesting reviews from all committers who I was able to find with git log --format="%aN <%aE>"| sort -u except for @austinsheep ... Unsure why I am not able to add you, but please review and approve:

Please add a comment like if you approve (as noted by vmx):

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to choose either at their option.

Background for this change is to align the license with other IPFS projects (see previous discussion for go-ipfs) triggered by rust-ipfs grant getting merged.

@koivunej
Copy link
Collaborator Author

Ok to switch licenses

@vmx
Copy link
Contributor

vmx commented Feb 20, 2020

A more formal approval would be (that's from ipfs/js-ipfs#2624):

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to choose either at their option.

@koivunej
Copy link
Collaborator Author

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to choose either at their option.

@aphelionz
Copy link
Contributor

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to choose either at their option.

@aphelionz
Copy link
Contributor

@vmx @koivunej Do we need everybody to copy and paste the approvals before we merge, or can we merge and move the approval to an issue thread or threads?

@rklaehn
Copy link
Member

rklaehn commented Feb 20, 2020

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to choose either at their option.

@koivunej
Copy link
Collaborator Author

koivunej commented Feb 21, 2020

The best possible outcome is that everyone goes through the PR, agrees and copypastes the approval since there are not so many agreements needed. I think the "merge" + "tracking approvals later" was done for clippy so there is nothing inherently problematic with that but perhaps the license part of readme would then need to changed to mark when the change happened, that previous license was ISC and all that (in similar fashion to go-ipfs/LICENSE). Hopefully all that be unnecessary.

EDIT: Forgot to mention: With clippy it seems that github contributors api query was used, since my way would not cover any Co-Authored-By fields and would look only at the Author field. I double-checked that the github Insights > People shows a similar list as have either been mentioned or requested a review.

@vmx
Copy link
Contributor

vmx commented Feb 21, 2020

@aphelionz as it isn't that many people only the approval from @dvc94ch @austinsheep and @gnunicorn are needed, I would rather trying to get in touch with them through other channels, let them comment here and then merge.

@aphelionz could you please try getting their approvals?

@aphelionz
Copy link
Contributor

@vmx I reached out to @austinsheep and now trying to track down @gunicorn

@aphelionz
Copy link
Contributor

And by @gunicorn I mean @gnunicorn of course

@aphelionz
Copy link
Contributor

@dvc94ch Procedural matter - you gotta copy/paste the following as a comment here:

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to choose either at their option.

@dvc94ch
Copy link
Contributor

dvc94ch commented Feb 21, 2020

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to choose either at their option.

@aphelionz
Copy link
Contributor

That just leaves @austinsheep and @gnunicorn . I've sent messages to each of them on Gitter @vmx.

dvc94ch pushed a commit to ipld/libipld that referenced this pull request Feb 23, 2020
dvc94ch pushed a commit to ipfs-rust/libipld-collections that referenced this pull request Feb 23, 2020
related to rs-ipfs/rust-ipfs#50

Please add a comment if you approve:

> I license past and future contributions under the dual MIT/Apache-2.0
license, allowing licensees to choose either at their option.
dvc94ch pushed a commit to ipfs-rust/ipld-daemon that referenced this pull request Feb 23, 2020
related to rs-ipfs/rust-ipfs#50

Please add a comment if you approve:

> I license past and future contributions under the dual MIT/Apache-2.0
license, allowing licensees to choose either at their option.
@gnunicorn
Copy link
Contributor

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to choose either at their option

@aphelionz
Copy link
Contributor

That just leaves @austinsheep!

@aubaugh
Copy link
Contributor

aubaugh commented Feb 23, 2020

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to choose either at their option

@dvc94ch dvc94ch merged commit 710635f into rs-ipfs:master Feb 23, 2020
@koivunej koivunej deleted the mit-apl branch March 2, 2020 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants