-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rs.read_precognition()
: Update docstring and set spacegroup
after parsing log
#135
Labels
Comments
Related to this issue, there's a bug in the logfile parsing of |
JBGreisman
changed the title
Mar 9, 2022
rs.read_precognition()
supports .ii filesrs.read_precognition()
: Update docstring and set spacegroup
after parsing log
Following additional discussion offline, this PR will
|
Awesome -- thanks! Two small clarifications:
|
JBGreisman
added a commit
that referenced
this issue
Mar 14, 2022
Fixed `read_precognition()` as per #135 and updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It came up today that
rs.read_precognition()
reads .ii files. This isn't explicitly stated in the docstring. It should be made more clear that the io function supports both file types.The text was updated successfully, but these errors were encountered: