Merge pull request #388 from cfis/synchronize_failed_urls

Synchronize self.failedURLs
SDWebImage · May 8, 2013 · 899d67b · 899d67b
2 parents 990df9f + 0426f07
commit 899d67b
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/SDWebImage/SDWebImageManager.m b/SDWebImage/SDWebImageManager.m
@@ -83,7 +83,13 @@ - (NSString *)cacheKeyForURL:(NSURL *)url
     __block SDWebImageCombinedOperation *operation = SDWebImageCombinedOperation.new;
     __weak SDWebImageCombinedOperation *weakOperation = operation;
 
-    if (!url || !completedBlock || (!(options & SDWebImageRetryFailed) && [self.failedURLs containsObject:url]))
+    BOOL isFailedUrl = NO;
+    @synchronized(self.failedURLs)
+    {
+        isFailedUrl = [self.failedURLs containsObject:url];
+    }
+
+    if (!url || !completedBlock || (!(options & SDWebImageRetryFailed) && isFailedUrl))
     {
         if (completedBlock) completedBlock(nil, nil, SDImageCacheTypeNone, NO);
         return operation;