-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-[SDWebImageDownloaderOperation URLSession:dataTask:didReceiveData:] crash #1998
Comments
|
@bpoplauschi |
@hongruqi we need you to fill the data in the template table, not leave it with example values.
|
|
|
|
The first crash is because of that |
The second one |
I am seeing this crash in version 4.1.0 of the SDK as well. Although it is not a very large crash.
|
Possible race condition? The |
@joshuafeldman It seems that there is an non-thread safe issue to that NSMutableData From the apple doc:
Maybe an simple solution is to make all the modify operation in the same queue(for example, put these in the SD's //line:231
self.imageData = nil;
//line:270
self.imageData = [[NSMutableData alloc] initWithCapacity:expected];
//line:441
[self.imageData setData:UIImagePNGRepresentation(image)]; Update: Instead of add that |
And also, all the process that read the image data should be called with |
Seems like a valid observation to me. Any timeline for getting this merged in? Would love to include it in our next release. |
It should on 4.1.1 but current we do not have an possible release date. @bpoplauschi Maybe we can review this PR and try to merge this to master branch(since this is a crash fix) |
Fixed via #2011 and will be released in 4.1.1 |
4.1.1 is now released. |
New Issue Checklist
Issue Info
Issue Description and Steps
Please fill in the detailed description of the issue (full output of any stack trace, compiler error, ...) and the steps to reproduce the issue.
Fatal Exception: NSInvalidArgumentException
-[NSMallocBlock appendData:]: unrecognized selector sent to instance 0x17184f000
The text was updated successfully, but these errors were encountered: